refactor: remove references of broadcastRawTransaction, use only broadcastTransaction #4900
Conversation
edgarkhanzadian
requested review from
kyranjamie,
pete-watters,
fbwoolf and
alter-eggo
There was a problem hiding this comment.
Nice work @edgarkhanzadian, really great getting a new set of eyes on this code and seeing improvements. 👍
|
This is great refactor, but a little concerned this changes behaviours of sponsors transactions, this logic isn't in the other broadcast fn right? |
Good point, thinking that can just be relocated? |
|
@fbwoolf @kyranjamie i tried replicating the sponsored functionality at 3e7af19 but i am not 100% sure that it works, how can i test it? |
I believe there is a sponsored tx in the test-app to use? |
Alex swap uses sponsored txs right @fbwoolf ? Can't we use that to test? |
|
@kyranjamie i tried with a test app and it seems to be working for me, we can also try alex swaps |
|
Also, noticed an infinite loop on fee UI. Sponsored transactions shouldn't have any fees, but there is currently an infinite loop caused by the useEffects. Fixed infiniteLoop.mov |
|
Merging. Please, don't include it in this release yet: #4918 |
edgarkhanzadian
force-pushed
the
refactor/remove-broadcast-raw-transaction
branch
from
c3a0354 to
0527317
Compare
edgarkhanzadian
force-pushed
the
refactor/remove-broadcast-raw-transaction
branch
from
cc5985d to
2a6b0a0
Compare
edgarkhanzadian
force-pushed
the
refactor/remove-broadcast-raw-transaction
branch
from
2a88579 to
f5ec86c
Compare
Instead of using broadcastRawTransaction in one place and broadcastTransaction in another, it would be better to use only one function everywhere for consistency. Here's my take on refactoring that part.
Testing with the broadcastTransaction:
signingContract.mov